Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove crate -> create #3355

Closed
janosh opened this issue Feb 9, 2024 · 3 comments · Fixed by #3537
Closed

remove crate -> create #3355

janosh opened this issue Feb 9, 2024 · 3 comments · Fixed by #3537
Labels
dictionary Changes to the dictionary duplicate

Comments

@janosh
Copy link
Contributor

janosh commented Feb 9, 2024

"crate" is a common word in programming (think rust crates) and should not be in the default set of corrections
@DimitriPapadopoulos DimitriPapadopoulos added duplicate dictionary Changes to the dictionary labels Feb 9, 2024
@DimitriPapadopoulos
Copy link
Collaborator

It's already in the rare dictionary, see #2281. Its place is between the code and rare dictionaries, there's no easy solution as far as I can see.

@janosh
Copy link
Contributor Author

janosh commented Feb 10, 2024

not sure i would put it in code as that's where this correction is most likely to be unwanted. since it shouldn't be in the default set imo, maybe just remove it altogether?

@DimitriPapadopoulos
Copy link
Collaborator

That's precisely why it should be in code.

luzpaz added a commit that referenced this issue Sep 9, 2024
@luzpaz
Move crate->create to code dictionary
ec7bf32 
Fixes #2281  
Fixes #3355  
Fix partially for #1660
@luzpaz luzpaz mentioned this issue Sep 9, 2024
Merged
DimitriPapadopoulos pushed a commit that referenced this issue Sep 9, 2024
@luzpaz @DimitriPapadopoulos
Move crate->create to code dictionary
1ad912c 
Fixes #2281  
Fixes #3355  
Fix partially for #1660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dictionary Changes to the dictionary duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move crate->create to code dictionary codespell-project/codespell
2 participants
@DimitriPapadopoulos @janosh