Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspell Tests Failing On Debian 12 #2897

Closed
korverdev opened this issue Jun 24, 2023 · 2 comments · Fixed by #2917
Closed

Aspell Tests Failing On Debian 12 #2897

korverdev opened this issue Jun 24, 2023 · 2 comments · Fixed by #2917

Comments

@korverdev
Copy link
Contributor

The error I'm running into on Debian 12:

______________ test_dictionary_formatting[/workspaces/codespell/codespell_lib/tests/../data/dictionary.txt-in_aspell0-in_dictionary0] ______________
codespell_lib/tests/test_dictionary.py:70: in test_dictionary_formatting
    raise AssertionError("\n" + "\n".join(errors))
E   AssertionError: 
E   error 'dateset' should not be in aspell dictionaries (en, en_GB, en_US, en_CA, en_AU) for dictionary /workspaces/codespell/codespell_lib/tests/../data/dictionary.txt
------------------------------------------- generated xml file: /workspaces/codespell/junit-results.xml --------------------------------------------
========================================================== 1 failed, 44 passed in 13.90s ===========================================================

On Debian 11, all tests pass.

I suspect this is caused by an update to the aspell package from 0.60.8-3 -> 0.60.8-4+b1.
@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Jun 25, 2023 •
edited
Loading

It looks like dateset has been added to recent aspell dictionaries. Yet it's not a word, as far as I know. Some hits which I believe are not common enough to consider it to be a word and not a common typo:

By the way, I wonder whether we should change dateset->dataset into dateset->dataset, date set,.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Jun 26, 2023
Merged
@korverdev korverdev mentioned this issue Jun 26, 2023
Merged
@DimitriPapadopoulos
Copy link
Collaborator

The obvious fix would be to move dateset to rare.

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this issue Jul 4, 2023
@DimitriPapadopoulos
Move dateset to rare
d70e0e3 
Although it's hardly a word, it appears to have been added
to the aspell dictionary:
codespell-project#2897
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Jul 4, 2023
Merged
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this issue Jul 4, 2023
@DimitriPapadopoulos
Move dateset to dictionary_code.txt
7774d78 
Although it's hardly a word, it appears to have been added
to the aspell dictionary:
codespell-project#2897

Not sure what the rationale for adding `dateset` to the aspell
dictionary is, but search engines show the context is usually
programming and source code, so `dictionary_code.txt` is probably
the best choice.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this issue Jul 4, 2023
@DimitriPapadopoulos
Move dateset to dictionary_code.txt
94a689c 
Although it's hardly a word, it appears to have been added
to the aspell dictionary:
codespell-project#2897

Not sure what the rationale for adding `dateset` to the aspell
dictionary is, but search engines show the context is usually
programming and source code, so `dictionary_code.txt` is probably
the best choice.
DimitriPapadopoulos added a commit that referenced this issue Jul 5, 2023
@DimitriPapadopoulos
Move dateset to dictionary_code.txt
5228e4d 
Although it's hardly a word, it appears to have been added
to the aspell dictionary:
#2897

Not sure what the rationale for adding `dateset` to the aspell
dictionary is, but search engines show the context is usually
programming and source code, so `dictionary_code.txt` is probably
the best choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move dateset to code DimitriPapadopoulos/codespell
2 participants
@DimitriPapadopoulos @korverdev