Skip to content

Commit

Permalink
Quote the skip list
Browse files Browse the repository at this point in the history 
Otherwise if people copy our example then change the skip list they can make invalid YAML
  • Loading branch information
@peternewman
peternewman authored Oct 6, 2022
1 parent 3ea9498 commit fd1d5c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/codespell.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ jobs:
with:
check_filenames: true
# When using this Action in other repos, the --skip option below can be removed
skip: ./.git,./codespell_lib/data,./example/code.c,test_basic.py,*.pyc,README.rst
skip: "./.git,./codespell_lib/data,./example/code.c,test_basic.py,*.pyc,README.rst"

3 comments on commit fd1d5c0

@peternewman
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch protection doesn't seem to work @larsoner as it still let me commit directly to master! I don't know what happens if my commit fails the actions...

@peternewman
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I suspect it's because of this:
"Organization and repository administrators
These members can always bypass required pull requests."

@larsoner
Copy link
Member

@larsoner larsoner commented on fd1d5c0 Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's green

I disabled the bypassing. I can live with toggling it temporarily if I'm making a release for example. Seems worth it given our collective master-push error rate :)

Please sign in to comment.