-
Notifications
You must be signed in to change notification settings - Fork 472
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
#!/bin/bash | ||
|
||
sudo apt-get update | ||
sudo apt-get install -y libaspell-dev | ||
|
||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -30,7 +30,6 @@ repos: | |||||||||||||||||||||||||||||
hooks: | ||||||||||||||||||||||||||||||
- id: no-commit-to-branch | ||||||||||||||||||||||||||||||
args: [--branch, main] | ||||||||||||||||||||||||||||||
- id: check-toml | ||||||||||||||||||||||||||||||
- id: check-yaml | ||||||||||||||||||||||||||||||
args: [--unsafe] | ||||||||||||||||||||||||||||||
- id: debug-statements | ||||||||||||||||||||||||||||||
|
@@ -48,45 +47,42 @@ repos: | |||||||||||||||||||||||||||||
- id: check-case-conflict | ||||||||||||||||||||||||||||||
- id: check-toml | ||||||||||||||||||||||||||||||
- repo: https://github.com/adrienverge/yamllint.git | ||||||||||||||||||||||||||||||
rev: v1.29.0 | ||||||||||||||||||||||||||||||
rev: v1.32.0 | ||||||||||||||||||||||||||||||
hooks: | ||||||||||||||||||||||||||||||
- id: yamllint | ||||||||||||||||||||||||||||||
args: | ||||||||||||||||||||||||||||||
- --no-warnings | ||||||||||||||||||||||||||||||
- -d | ||||||||||||||||||||||||||||||
- '{extends: relaxed, rules: {line-length: {max: 90}}}' | ||||||||||||||||||||||||||||||
- repo: https://github.com/charliermarsh/ruff-pre-commit | ||||||||||||||||||||||||||||||
rev: v0.0.254 | ||||||||||||||||||||||||||||||
rev: v0.0.280 | ||||||||||||||||||||||||||||||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
kurtmckee
Author
Contributor
|
[project.optional-dependencies] | |
dev = [ | |
"build", | |
"chardet", | |
"pre-commit", | |
"pytest", | |
"pytest-cov", | |
"pytest-dependency", | |
"Pygments", | |
"ruff", |
The latest version of ruff is installed and then run in CI:
codespell/.github/workflows/codespell-private.yml
Lines 47 to 50 in f94af94
pip install -e ".[dev]" # install the codespell dev packages | |
- run: codespell --help | |
- run: codespell --version | |
- run: make check |
This is an ongoing risk that cannot be avoided unless:
- dev dependencies are pinned (to prevent new versions with unknown bugs)
- Duplicate checks are removed (to avoid drift between duplicated linting tool versions)
I recommend pinning all dev dependencies to known-working versions, and then removing duplicate checks in the Makefile
which are handled automatically by pre-commit.
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
DimitriPapadopoulos
Aug 9, 2023
Collaborator
Ah, my wrong then. I thought all checks had been moved to pre-commit by #2969. But we need to replace this rule too, which is triggerred by make check
:
ruff:
ruff .
I'll change it to:
ruff:
pre-commit run --all-files ruff
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,3 +59,6 @@ pytest: | |
|
||
clean: | ||
rm -rf codespell.1 | ||
|
||
mypy: | ||
mypy . |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
from ._codespell import _script_main, main | ||
from ._version import __version__ | ||
from ._version import __version__ # type: ignore | ||
|
||
__all__ = ["_script_main", "main", "__version__"] |
@kurtmckee What does
rev: v0.0.280
mean exactly?The current specification is
v0.0.282
but pre-commit CI jobs runv0.0.283
. See #3014.