Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to use node20 runtime #71

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Sep 5, 2023

Description:

Node12 was deleted from the runner recently. And Node 16 reaches the end of life soon on 11 Sep 2023. This PR updates the default runtime to node20 (Node 20). I have also bumped the actions/checkout version to v4 for the same. (actions/runner#2732)


A major version bump might be needed after the PRs merge.

@cclauss
Copy link
Contributor

cclauss commented Feb 25, 2024

Mostly a duplicate of the Dependabot automated:

Please rebase so we can land the important change to codespell-problem-matcher/action.yml.

@kbdharun kbdharun changed the title feat: bump to use node20 runtime, actions/checkout to v4 feat: bump to use node20 runtime Feb 25, 2024
@DimitriPapadopoulos
Copy link
Collaborator

I tried to rebase, but unfortunately a new error appeared: enabling pre-commit for all repositories without creating a .pre-commit-config.yaml file for each directory was an error.

@kbdharun
Copy link
Contributor Author

Thanks for rebasing @DimitriPapadopoulos . Just now, noticed the previous comment.

Updated the PR title for the same.

@DimitriPapadopoulos
Copy link
Collaborator

Could you create a minimal .pre-commit-config.yaml to pass tests? I don't have rights to merge pull requests that don't pass tests.

@kbdharun
Copy link
Contributor Author

Could you create a minimal .pre-commit-config.yaml to pass tests? I don't have rights to merge pull requests that don't pass tests.

Merged changes from #75 for this.

@DimitriPapadopoulos
Copy link
Collaborator

@peternewman @larsoner Could you have a look and merge this?

@larsoner larsoner merged commit 3174815 into codespell-project:master Feb 26, 2024
6 checks passed
@larsoner
Copy link
Member

Thanks @kbdharun @cclauss !

renovate bot referenced this pull request in allenporter/flux-local Aug 19, 2024
#784)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[codespell-project/actions-codespell](https://togithub.com/codespell-project/actions-codespell)
| action | minor | `v2.0` -> `v2.1` |

---

### Release Notes

<details>
<summary>codespell-project/actions-codespell
(codespell-project/actions-codespell)</summary>

###
[`v2.1`](https://togithub.com/codespell-project/actions-codespell/releases/tag/v2.1)

[Compare
Source](https://togithub.com/codespell-project/actions-codespell/compare/v2.0...v2.1)

#### What's Changed

- Use v2 in README by
[@&#8203;okuramasafumi](https://togithub.com/okuramasafumi) in
[https://github.com/codespell-project/actions-codespell/pull/69](https://togithub.com/codespell-project/actions-codespell/pull/69)
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/codespell-project/actions-codespell/pull/72](https://togithub.com/codespell-project/actions-codespell/pull/72)
- Bump actions/setup-python from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/codespell-project/actions-codespell/pull/74](https://togithub.com/codespell-project/actions-codespell/pull/74)
- feat: bump to use node20 runtime by
[@&#8203;kbdharun](https://togithub.com/kbdharun) in
[https://github.com/codespell-project/actions-codespell/pull/71](https://togithub.com/codespell-project/actions-codespell/pull/71)
- \[pre-commit.ci] pre-commit autoupdate by
[@&#8203;pre-commit-ci](https://togithub.com/pre-commit-ci) in
[https://github.com/codespell-project/actions-codespell/pull/76](https://togithub.com/codespell-project/actions-codespell/pull/76)

#### New Contributors

- [@&#8203;okuramasafumi](https://togithub.com/okuramasafumi) made their
first contribution in
[https://github.com/codespell-project/actions-codespell/pull/69](https://togithub.com/codespell-project/actions-codespell/pull/69)
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[https://github.com/codespell-project/actions-codespell/pull/72](https://togithub.com/codespell-project/actions-codespell/pull/72)
- [@&#8203;kbdharun](https://togithub.com/kbdharun) made their first
contribution in
[https://github.com/codespell-project/actions-codespell/pull/71](https://togithub.com/codespell-project/actions-codespell/pull/71)
- [@&#8203;pre-commit-ci](https://togithub.com/pre-commit-ci) made their
first contribution in
[https://github.com/codespell-project/actions-codespell/pull/76](https://togithub.com/codespell-project/actions-codespell/pull/76)

**Full Changelog**:
codespell-project/actions-codespell@v2...v2.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants