feat: Support approve/reject all button: #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display the cards in cols instead of rows - Create an approve all btn to approve all vacation requests - Create reject all btn to reject all vacation requests
ghost
marked this pull request as draft
…es their pending requests
zaelgohary
reviewed
Aug 28, 2024
|
Pagination is not updated when doing approve all or reject all. screen-capture.1.webm |
zaelgohary
requested changes
Sep 8, 2024
…ps/CSHR into development_approve_all_pending_requests
…ll of the pending requests.
Not yet resolved.
|
Mahmoud-Emad
force-pushed
the
development_approve_all_pending_requests
branch
from
25a9ea3 to
05154d2
Compare
|
Issue is still not fixed. Request is being shown as pending while it's approved in the network tab.
|
|
Also, the notifications are messed up as the notification that should appear to the supervisor, gets shown to the user.
|
zaelgohary
reviewed
Oct 29, 2024
Mahmoud-Emad
force-pushed
the
development_approve_all_pending_requests
branch
from
63a6a2e to
26c76b0
Compare
- Fix the 'unique_together' issue. - Fix approving all vacations. - Fix updating the status of the vacations. - Update the vacation balance after the user do the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the pagination count in pending requests and display the cards as columns not rows and implement a new button for approving/rejecting all pending requests
Changes
Related Issues
Checklist