Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rtl option #774

Closed
wants to merge 3 commits into from
Closed

Conversation

jerrywu001
Copy link
Contributor

@jerrywu001 jerrywu001 commented Feb 28, 2023

What kind of change does this pull request introduce?

feature: add rtl option (so easy to rtl layout)

  • usage
export const RtlLayout: React.FC = () => {
  return (
    <>
      <Sandpack
        options={{
          rtl: true,
        }}
        template="react"
      />
    </>
  );
};

image

Checklist

  • Documentation;
  • Storybook (if applicable);
  • Tests;
  • Ready to be merged;

@vercel
Copy link

vercel bot commented Feb 28, 2023

@jerrywu001 is attempting to deploy a commit to the CodeSandbox Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c882ee:

Sandbox Source
Sandpack Configuration

sandpack-react/src/presets/Sandpack.tsx Outdated Show resolved Hide resolved
sandpack-react/src/presets/Sandpack.tsx Outdated Show resolved Hide resolved
sandpack-react/src/types.ts Show resolved Hide resolved
@jerrywu001 jerrywu001 force-pushed the feat/rtl-option branch 2 times, most recently from bb96aed to 7e94b12 Compare February 28, 2023 11:30
Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Can you please update your branch from main?

sandpack-react/src/presets/Sandpack.tsx Outdated Show resolved Hide resolved
@jerrywu001 jerrywu001 requested a review from danilowoz February 28, 2023 20:01
@jerrywu001 jerrywu001 closed this Mar 1, 2023
@jerrywu001
Copy link
Contributor Author

to #780

@jerrywu001 jerrywu001 deleted the feat/rtl-option branch March 1, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants