feat: add vue-ts vue3-ts template #650
Conversation
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53e4577:
|
|
In daily development, the VUE3-TS is widely used. It is recommended to merge. |
|
Hey @jerrywu001, I loved your contribution! But let's keep the minimal necessary files to run a project, so I'd recommend removing the button and counter and leaving only a Hello world. Maybe the word What do you think? |
Ok, let me do some change. |
@danilowoz Done. |
| @@ -0,0 +1,123 @@ | |||
| /** | |||
There was a problem hiding this comment.
I was wondering, is there any reason why we still maintain vue instead only vue3? At some point in the future we can sunset it and provide only the latest version of Vue
There was a problem hiding this comment.
Yeah, we spoke internally, and let's focus on vue3 only. This means we can remove this file and keep the original vue template, and on the next major release, we'll remove the vue template in favor of the vue3.
| </script> | ||
|
|
||
| <template> | ||
| code: `<template> | ||
| <h1>Hello {{ msg }}</h1> | ||
| </template> |
There was a problem hiding this comment.
Missing a line break between template and script?
…typescript-template
…sandpack into feat/vue-typescript-template
|
Someone is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
The vue-ts template has been removed. @danilowoz |
What kind of change does this pull request introduce?
Feature:
I checked it and it works fine.
@danilowoz In daily development, the VUE3-TS is widely used. It is recommended to merge.