Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HeroDesktop.tsx to fix link access #545

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

psullivan6
Copy link
Contributor

@psullivan6 psullivan6 commented Jul 29, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

What kind of change does this pull request introduce?

Tiny CSS layout bug fix

What is the current behavior?

On a larger monitor (3377 x 1304) the description overlaps the top links, making it impossible to interact with the links. This can be "resolved" by scrolling down the page, but they're not interactive on initial load.

What is the new behavior?

Added a z-index CSS property to the parent container of the interactive content to ensure it's above the description and thus interactive.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Added the same CSS in the browser dev tools and was able to resolve the issue
  2. Removed the CSS in the browser dev tools and was able to see the issue re-appear

Checklist

  • Documentation; N/A
  • Storybook (if applicable); N/A
  • Tests;
  • Ready to be merged;

Changelog

  • added zIndex: 1 to the parent container of the header links to ensure they are interactive. This specifically targets larger screen sizes where the description overlaps the Clipboard and Resources content

- added `zIndex: 1` to the parent container of the header links to ensure they are interactive. This specifically targets larger screen sizes where the description overlaps the `Clipboard` and `Resources` content
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 159d36d:

Sandbox Source
Sandpack Configuration

@danilowoz danilowoz merged commit fa90190 into codesandbox:main Aug 1, 2022
@danilowoz
Copy link
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants