Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical component for nested sandpack on the documentation #177

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

zehfernandes
Copy link
Contributor

@sannek here is the vertical component. I would like to customize more the second preview but that will require not used the Sandpack component and loose all the default styles. Maybe in a next iteration?

image

Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zehfernandes is it ready to be merged? It looks good to me

@sannek
Copy link
Contributor

sannek commented Nov 25, 2021

Awesome, thanks Zeh!
I don't think - at least for now - we should further customize the preview. It might look nicer, but will make it no longer a good preview of what it would really look like when people use it in their projects.

@zehfernandes zehfernandes merged commit 2f50573 into main Nov 25, 2021
@zehfernandes zehfernandes deleted the feat/vertical-sandpack branch November 25, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants