Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs content #175

Merged
merged 4 commits into from
Nov 25, 2021
Merged

docs: improve docs content #175

merged 4 commits into from
Nov 25, 2021

Conversation

tromika
Copy link
Contributor

@tromika tromika commented Nov 24, 2021

What kind of change does this pull request introduce?

Improving the docs, fixing typos, and making sure the documentation is clear.

What is the new behavior?

The docs are crystal clear.

Checklist

  • Documentation
  • Ready to be merged

@tromika tromika changed the title improve custom content docs docs: improve docs content Nov 24, 2021
@vercel vercel bot temporarily deployed to Preview – sandpack November 24, 2021 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing November 24, 2021 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack November 24, 2021 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing November 24, 2021 14:27 Inactive
@tromika
Copy link
Contributor Author

tromika commented Nov 24, 2021

@sannek added some improvements from my side. For the rest, for me, it's logically clear. On the other hand, I can't assess in many cases it's clear enough to use it.

@tromika tromika requested a review from sannek November 24, 2021 20:51
@vercel vercel bot temporarily deployed to Preview – sandpack November 24, 2021 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack-landing November 24, 2021 21:04 Inactive
@sannek
Copy link
Contributor

sannek commented Nov 25, 2021

Looks good to me! I suppose I should also use this branch to do my copy editing/nitpicking, because otherwise i'm looking at dated stuff?

I'll fix the merge conflict and go over it as well.

@tromika
Copy link
Contributor Author

tromika commented Nov 25, 2021

Yes please! Also I'm still planning to go through on this once again. So it's a good collaborative experience in CSB projects! Thanks!

@vercel vercel bot temporarily deployed to Preview – sandpack-landing November 25, 2021 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview – sandpack November 25, 2021 12:55 Inactive
@sannek
Copy link
Contributor

sannek commented Nov 25, 2021

Actually - i realised that my interactive examples aren't on this branch - so we really should merge this one asap and get on a new branch.

I'm still finishing up on the custom-content guide, but I'm a bit stuck on it so figured I'd take a little break to edit the rest first.

@zehfernandes zehfernandes merged commit 6eccfee into main Nov 25, 2021
@zehfernandes zehfernandes deleted the docs/improve-docs-content branch November 25, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants