Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add allow-downloads to iframes #1054

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: add allow-downloads to iframes #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sandpack-client/src/clients/runtime/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class SandpackRuntime extends SandpackClient {
if (!this.iframe.getAttribute("sandbox")) {
this.iframe.setAttribute(
"sandbox",
"allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts"
"allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts allow-downloads allow-pointer-lock"
);

this.iframe.setAttribute(
Expand Down
2 changes: 1 addition & 1 deletion sandpack-client/src/clients/static/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class SandpackStatic extends SandpackClient {
if (!this.iframe.getAttribute("sandbox")) {
this.iframe.setAttribute(
"sandbox",
"allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts"
"allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts allow-downloads allow-pointer-lock"
);

this.iframe.setAttribute(
Expand Down
Loading