fix(sandpack-react): make entry field optional, as bundler relies on …

…package.json (#660)
codesandbox · Dec 12, 2022 · 3d12b6e · 3d12b6e
1 parent 035d1b9
commit 3d12b6e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/sandpack-client/src/utils.test.ts b/sandpack-client/src/utils.test.ts
@@ -122,8 +122,8 @@ describe(normalizePath, () => {
   });
 
   it("doesn't tranform invalid values", () => {
-    expect(normalizePath(null)).toBe(undefined);
-    expect(normalizePath(undefined)).toBe(undefined);
-    expect(normalizePath(123)).toBe(undefined);
+    expect(normalizePath(undefined)).toBe(null);
+    expect(normalizePath(null)).toBe(null);
+    expect(normalizePath(123)).toBe(null);
   });
 });
diff --git a/sandpack-client/src/utils.ts b/sandpack-client/src/utils.ts
@@ -202,5 +202,5 @@ export const normalizePath = <R extends any>(path: R): R => {
     );
   }
 
-  return undefined as R;
+  return null as R;
 };
diff --git a/sandpack-react/src/types.ts b/sandpack-react/src/types.ts
@@ -610,7 +610,7 @@ export interface SandboxTemplate {
   files: Record<string, SandpackFile>;
   dependencies: Record<string, string>;
   devDependencies?: Record<string, string>;
-  entry: string;
+  entry?: string;
   main: string;
   environment: SandboxEnvironment;
 }

diff --git a/sandpack-react/src/utils/sandpackUtils.ts b/sandpack-react/src/utils/sandpackUtils.ts
@@ -76,7 +76,7 @@ export const getSandpackStateFromProps = (
   }
 
   // Make sure it resolves the entry file
-  if (!projectSetup.files[projectSetup.entry]) {
+  if (projectSetup.entry && !projectSetup.files[projectSetup.entry]) {
     /* eslint-disable */
     // @ts-ignore
     projectSetup.entry = resolveFile(projectSetup.entry, projectSetup.files);
@@ -222,7 +222,7 @@ const combineTemplateFilesToSetup = ({
       ...baseTemplate.devDependencies,
       ...customSetup?.devDependencies,
     },
-    entry: normalizePath(customSetup?.entry || baseTemplate.entry),
+    entry: normalizePath(customSetup?.entry),
     main: baseTemplate.main,
     environment: customSetup?.environment || baseTemplate.environment,
   } as SandboxTemplate;
-Original file line number
+Diff line change
@@ Expand Up @@
         );
       }
-      return undefined as R;
+      return null as R;
     };