fix(use-files): make files reference more stable (#760)

codesandbox · Feb 24, 2023 · 32ab419 · 32ab419 · vercel · Feb 24, 2023
1 parent 721ad28
commit 32ab419
Show file tree

Hide file tree

Showing 11 changed files with 125 additions and 469 deletions.
diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json
@@ -1,5 +1,5 @@
 {
   "packages": ["sandpack-client", "sandpack-react"],
-  "sandboxes": ["sowx8r"],
+  "sandboxes": ["sowx8r", "909l3f"],
   "node": "16"
 }
diff --git a/sandpack-client/package.json b/sandpack-client/package.json
@@ -47,11 +47,10 @@
   ],
   "dependencies": {
     "@codesandbox/nodebox": "0.1.0",
-    "lodash.isequal": "^4.5.0",
+    "dequal": "^2.0.2",
     "outvariant": "1.3.0"
   },
   "devDependencies": {
-    "@types/lodash.isequal": "^4.5.2",
     "@types/node": "^9.3.0",
     "console-feed": "3.3.0",
     "del": "^6.0.0",

diff --git a/sandpack-client/src/clients/base.ts b/sandpack-client/src/clients/base.ts
@@ -1,4 +1,4 @@
-import isEqual from "lodash.isequal";
+import { dequal as deepEqual } from "dequal";
 
 import type {
   ClientOptions,
@@ -35,7 +35,7 @@ export class SandpackClient {
    * Clients handles
    */
   public updateOptions(options: ClientOptions): void {
-    if (!isEqual(this.options, options)) {
+    if (!deepEqual(this.options, options)) {
       this.options = options;
       this.updateSandbox();
     }

diff --git a/sandpack-client/src/clients/runtime/index.ts b/sandpack-client/src/clients/runtime/index.ts
@@ -1,4 +1,4 @@
-import isEqual from "lodash.isequal";
+import { dequal as deepEqual } from "dequal";
 
 import type { SandpackMessage } from "../..";
 import { nullthrows } from "../..";
@@ -163,7 +163,7 @@ export class SandpackRuntime extends SandpackClient {
   }
 
   updateOptions(options: ClientOptions): void {
-    if (!isEqual(this.options, options)) {
+    if (!deepEqual(this.options, options)) {
       this.options = options;
       this.updateSandbox();
     }

diff --git a/sandpack-react/package.json b/sandpack-react/package.json
@@ -35,6 +35,7 @@
     "README.md"
   ],
   "dependencies": {
+    "use-deep-compare-effect": "1.8.1",
     "@code-hike/classer": "^0.0.0-aa6efee",
     "@codemirror/autocomplete": "^6.4.0",
     "@codemirror/commands": "^6.1.3",
@@ -51,7 +52,7 @@
     "ansi-to-react": "6.1.6",
     "clean-set": "^1.1.2",
     "codesandbox-import-util-types": "^2.2.3",
-    "lodash.isequal": "^4.5.0",
+    "dequal": "^2.0.2",
     "lz-string": "^1.4.4",
     "react-devtools-inline": "4.4.0",
     "react-is": "^17.0.2"
@@ -66,7 +67,6 @@
     "@testing-library/react-hooks": "8.0.1",
     "@types/fs-extra": "^5.0.4",
     "@types/glob": "^5.0.35",
-    "@types/lodash.isequal": "^4.5.2",
     "@types/lz-string": "^1.3.34",
     "@types/node": "^9.4.6",
     "@types/react": "^18.0.15",