Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-lite]: Support test mode and jsx files #6853

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

mattphillips
Copy link
Contributor

@mattphillips mattphillips commented Aug 26, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

What kind of change does this PR introduce?

  • Add support for .jsx test files (.tsx is already supported so seems strange that jsx isn't - not sure if I missing something?)
  • Add missing mode value to Codesandbox add_test event. This value is part of the jest-circus event and would be useful to propagate as part of the codesandbox event.

By adding this missing mode it will be easier to report the tests correctly in SandpackTests which currently assumes anything not running/pass/fail to be skipped which isn't strictly true.

You can see that mode is part of the jest-circus event type here and here

cc/ @danilowoz

What is the current behavior?

  • jsx tests aren't found
  • mode isn't sent as part of the payload

What is the new behavior?

  • jsx tests should be found
  • mode will be sent as part of the payload

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

I've not tested this

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c709985:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Aug 26, 2022

Build for latest commit c709985 is at https://pr6853.build.csb.dev/s/new.

@danilowoz danilowoz merged commit 641aa2b into codesandbox:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants