-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial solver library #6
Conversation
Signed-off-by: Peter Gordon <[email protected]>
(I _really_ shouldn't be committed so much in one fell swoop next time...)
Needs to be reworked. Signed-off-by: Peter Gordon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far; but needs cleanup:
- Remove obsolete commented code.
- Fix some comments & docs.
__tests__/lib/guesserStrategies/letterFrequencyStrategy.test.ts
Outdated
Show resolved
Hide resolved
__tests__/lib/guesserStrategies/retryMisplacedLetterStrategy.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Gordon <[email protected]>
Signed-off-by: Peter Gordon <[email protected]>
Signed-off-by: Peter Gordon <[email protected]>
Signed-off-by: Peter Gordon <[email protected]>
Remove unused guesserStrategiesSpyOn helper method.
Complete commented thought.
I cannot approve my own PRs in GitHub since I am the one who created them; but for good due process I prefer to use them instead of directly committing to the default branch. This comment plus checking the "Merge without waiting for requirements to be met (bypass branch protections)" option above together constitute approval in lieu of that. |
This is the initial implementation of the solver logic. Details WIP.
NB: This is a draft in progress, for visibility of CI workflow and code changes; and is NOT intended to be merged yet.