Skip to content

Commit

Permalink
Temporarily turn on test (shoud fail on 10.2)
Browse files Browse the repository at this point in the history
  • Loading branch information
codereport committed Feb 4, 2021
1 parent 5b6dcd1 commit ac86d89
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions cpp/tests/groupby/group_count_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -243,18 +243,17 @@ TYPED_TEST(FixedPointTestBothReps, GroupBySumProductMinMaxDecimalAsValue)
// commented out until we drop support for CUDA 10.2
// group_by hash tests

// auto agg5 = cudf::make_sum_aggregation();
// test_single_agg(keys, vals, expect_keys, expect_vals_sum, std::move(agg5));
auto agg5 = cudf::make_sum_aggregation();
test_single_agg(keys, vals, expect_keys, expect_vals_sum, std::move(agg5));

// auto agg6 = cudf::make_min_aggregation();
// test_single_agg(keys, vals, expect_keys, expect_vals_min, std::move(agg6));
auto agg6 = cudf::make_min_aggregation();
test_single_agg(keys, vals, expect_keys, expect_vals_min, std::move(agg6));

// auto agg7 = cudf::make_max_aggregation();
// test_single_agg(keys, vals, expect_keys, expect_vals_max, std::move(agg7));
auto agg7 = cudf::make_max_aggregation();
test_single_agg(keys, vals, expect_keys, expect_vals_max, std::move(agg7));

// auto agg8 = cudf::make_product_aggregation();
// EXPECT_THROW(test_single_agg(keys, vals, expect_keys, {}, std::move(agg8)),
// cudf::logic_error);
auto agg8 = cudf::make_product_aggregation();
EXPECT_THROW(test_single_agg(keys, vals, expect_keys, {}, std::move(agg8)), cudf::logic_error);
}
}

Expand Down

0 comments on commit ac86d89

Please sign in to comment.