Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Enabling 'single-host' route exposure strategy by default #35

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ibuziuk
Copy link
Collaborator

@ibuziuk ibuziuk commented Nov 6, 2020

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Nov 6, 2020

@pdaverh as we discussed on the prio call - single-host is expected to be enabled by default

@MatousJobanek
Copy link
Contributor

MatousJobanek commented Nov 6, 2020

@ibuziuk is this going to work (and should be applied) also in CRT cluster? if not then let's create a separate file for OSD Sandbox stuff. if yes, then please update also the che_cluster.yaml file

@alexeykazakov
Copy link
Contributor

Yeah.. we need to keep both che and crw configuration in sync (see https://github.com/codeready-toolchain/toolchain-infra/blob/master/config/operators/che/che_cluster.yaml). So, no matter what operator we use (che or crw) in different environments we use the same configuration. Unless there is a good reason to have different configurations.

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Nov 6, 2020

@alexeykazakov @MatousJobanek why can't we simply drop che_cluster.yaml? I thought that the business decision is to run against the product (not the project)?

@alexeykazakov
Copy link
Contributor

alexeykazakov commented Nov 6, 2020

We haven't switched crt-stage to CRW yet. It's still running Che.

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Nov 6, 2020

ok, updated che also, but I believe we should consider dropping the project setup and focus only on the product in the short run

@alexeykazakov
Copy link
Contributor

Hm.. This doesn't work in Che 7.19.2. It breaks dashboard login.

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Nov 10, 2020

There is a known issue for switching between multihost & single host - eclipse-che/che#17886
However, since we are currently planning to use single-host from the very beginning we will not be affected.
Workaround for switching between multihost & singlehost - eclipse-che/che#17886 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants