Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code 1.34.0 #746

Closed
wants to merge 5 commits into from
Closed

VS Code 1.34.0 #746

wants to merge 5 commits into from

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jun 4, 2019

No description provided.

Also updated Typescript to fix a compilation error and removed some
dependencies in the server package that already exist in the root.
@code-asher code-asher requested a review from kylecarbs as a code owner June 4, 2019 22:26
@code-asher code-asher added the wip label Jun 4, 2019
For some reason in TypeScript the instanceof check isn't working. In
plain JavaScript it works fine.
@code-asher code-asher removed the wip label Jun 5, 2019
@alippai
Copy link

alippai commented Jun 10, 2019

1.35 is released, maybe you can target it in one go. It doesn't look like it changes a lot (but e.g. it uses TypeScript 3.5.1)

@hgw77
Copy link

hgw77 commented Jul 5, 2019

1.36.0 is released ;-)

@code-asher
Copy link
Member Author

code-asher commented Jul 17, 2019

Made obsolete by the new web branch (it currently targets 1.36.0). #857

@code-asher code-asher closed this Jul 17, 2019
@code-asher code-asher deleted the feature/vsc-1.34.0 branch July 17, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants