install.sh: Add remote install support #1996
Conversation
install.sh
Outdated
| @@ -303,7 +311,7 @@ install_aur() { | |||
| sh_c mkdir -p "$CACHE_DIR/code-server-aur" | |||
| sh_c "curl -#fsSL https://aur.archlinux.org/cgit/aur.git/snapshot/code-server.tar.gz | tar -xzC $CACHE_DIR/code-server-aur --strip-components 1" | |||
| echo "+ cd $CACHE_DIR/code-server-aur" | |||
| if [ ! "${DRY_RUN-}" ]; then | |||
| if sh_f [ ! "${DRY_RUN-}" ]; then | |||
There was a problem hiding this comment.
sh_f isn't needed here I think since DRY_RUN is a local flag.
install.sh
Outdated
| @@ -319,11 +327,11 @@ install_standalone() { | |||
| "$CACHE_DIR/code-server-$VERSION-$OS-$ARCH.tar.gz" | |||
|
|
|||
| sh_c="sh_c" | |||
| if [ ! -w "$STANDALONE_INSTALL_PREFIX" ]; then | |||
| if sh-f [ ! -w "$STANDALONE_INSTALL_PREFIX" ]; then | |||
There was a problem hiding this comment.
| if sh-f [ ! -w "$STANDALONE_INSTALL_PREFIX" ]; then | |
| if sh_f [ ! -w "$STANDALONE_INSTALL_PREFIX" ]; then |
| -h | --h | -help | --help) | ||
| usage | ||
| exit 0 | ||
| ;; | ||
| *) | ||
| SSH_ARGS="$1" | ||
| ;; | ||
| -*) |
There was a problem hiding this comment.
I think -* needs to come before * since * will match everything.
install.sh
Outdated
|
|
||
| # Always runs. | ||
| sh_f() { | ||
| if [ "$SSH_ARGS" ]; then |
install.sh
Outdated
| humanpath() { | ||
| sed "s# $HOME# ~#g; s#\"$HOME#\"\$HOME#g" | ||
| sed "s# $RHOME# ~#g; s#\"$RHOME#\"\$RHOME#g" |
There was a problem hiding this comment.
Should we use HOME (or ~) for the literal instead of RHOME? In the standalone case it'll output instructions that won't work as-is:
Please extend your path to use code-server:
PATH="$RHOME/.local/bin:$PATH"
Then you can run:
code-server
There was a problem hiding this comment.
~ is not supported in early init scripts before the shell started. $HOME is preferred.
|
Yea I think I'ma update all the docs/messages when installing remotely and modify fetch to fetch locally and then copy over ssh so that it works in closed off environments. |
nhooyr
force-pushed
the
remote-install-0e27
branch
5 times, most recently
from
7b3b988
to
bcf032e
Compare
install.sh
Outdated
| # Always runs. | ||
| sh_f() { | ||
| if [ "$SSH_ARGS" ]; then | ||
| mkdir -p ~/.ssh/sockets |
There was a problem hiding this comment.
The ~/.ssh directory requires to have 700 for openssh to accept it. It should probably be chmoded to that.
nhooyr
force-pushed
the
remote-install-0e27
branch
from
bcf032e
to
aeae326
Compare
nhooyr
force-pushed
the
remote-install-0e27
branch
from
aeae326
to
a5387a4
Compare
|
This got messy quickly, opening a follow up PR without |
Closes coder/sshcode#185, #1996, and pretty much archives that repository.
See also #1991