-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support naming on pod and scope #129
Conversation
@pionxzh what do you mean by hint and style? |
How do we intend to manage the name state? It seems that you only maintain the pod names during one-time visit life-cycle in this PR. I just wonder which mode we should design
It involves some back-end DB and yjs server works. I can work on it after we agree on either mode. |
Good point. Actually I didn't check did it really get persisten to the DB or not, but it did remember my changes after reloading. I prefer the idea of syncing pod name to DB and YJS. |
Oh I mean the user interaction things like
And some problems like:
|
Yes, it is persisted to DB, as you re-used the (currently unused but synced) This PR is good for now, I'm gonna merge it. we can later add yjs sync amount shared users in another PR (using "sync by DB and yjs server" design). Not too urgent though, @li-xin-yi if you have time, feel free to take lead on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature, thanks Pionxzh!
closes #97
long text will become an ellipsis.

We can further improve some of the controlling behaviors around this name input field. (hint, style, arrow key navigation)