Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindDPCPP to find new include path #144

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update FindDPCPP to find new include path #144

merged 1 commit into from
Mar 12, 2024

Conversation

Rbiessy
Copy link
Collaborator

@Rbiessy Rbiessy commented Mar 12, 2024

  • Update FindDPCPP.cmake to be able to find the new path to the include path
  • Removed branch if(NOT DPCPP_FOUND) return() as find_package_handle_standard_args will already fail with an error if either required vars cannot be found

Tested with modules compiler/2023.0.0 and compiler/2024.0.2.

Checklist

Tick if relevant:

  • [N/A] New files have a copyright
  • [N/A] New headers have an include guards
  • [N/A] API is documented with Doxygen
  • [N/A] New functionalities are tested
  • Tests pass locally
  • [N/A] Files are clang-formatted

Copy link
Contributor

@hjabird hjabird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a go with clang++ built from intel/llvm and that also seemed to work.

@Rbiessy Rbiessy merged commit 653fde8 into main Mar 12, 2024
1 check passed
@Rbiessy Rbiessy deleted the romain/fix_clang branch March 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants