Allow sharded cluster with custom directory/executable provider to be restarted #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a specific directory is possible
|
I like what it does but I don't like the way it does it. Not that there is anything immediately wrong, it is just not my style. I've been wanting to work on this but I just can't seem to find the time. I hope you are not waiting for this to get done soon, I'm swamped. |
|
Thanks for the feedback :) I am not waiting for it to be done soon. We just stumbled over it at work but have a workaround. If you have any specific ideas as to how you would tackle this bug I could offer to implement another solution to it - once you have the time for it, of course! Have a nice Sunday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
If a sharded cluster is started in a custom directory, stopped and then restarted again, it fails. The underlying reason appears to be that the files specified via the
cluster-config-filedirective cannot be reused.Proposed solution
When a
RedisInstanceis stopped, itsredis.confis parsed and allcluster-config-filedirectives looked up. All of these cluster config files are resolved against the folder the Redis executable resides in and, if present, are deleted.