pass Transaction to validFor

[AlexErrant]

I'm using codemirror as a searchbox. I have two "types" of autocompletions:

1. Historical, i.e. previous things you've searched for.
2. Syntactical, i.e. typing kind: will give you different "kinds" of cards that you can search for.

I'm using activateOnCompletion to get completion after accepting another completion. I'm also using validFor to make historical completions work since they may have spaces.

However, as seen in this demo video, the historical completion is "overriding" the syntactical completion because the validFor is still returning true even after the initial completion was accepted. You can play with the searchbox here.

This PR passes the Transaction to validFor. Using that transaction, I can call tr.isUserEvent('input.complete') and break out of validFor. I used pnpm patch to test this new behavior in a branch of my project and it works the way I want.

[marijnh]

Would it maybe make more sense to always reset existing completions when picking a completion?

[AlexErrant]

Yeah, I can't think of a scenario where someone would want to keep the existing completions after accepting one of them. I tried to avoid potentially breaking behavior by making a small additive change. But if you also think it would make sense for validFor to always return false after accepting a completion, that'd work for me!

[marijnh]

I've pushed an alternative patch, which cleans up some of the state transition handling, and does not add this argument to validFor.