can specify from transition as :any #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works because when we call add_state we build a table of known states
gnufied
pushed a commit
that referenced
this pull request
Oct 15, 2013
can specify from transition as :any
|
i had one comment: maybe we should support 2 formats: transitions from: :any # already supported
transitiosn from: [:any] # any can be part of arrayalthough there is no solid reason why we should support option 2, ive often seen rails guys sticking to the convention that resources :posts, only: :index
resources :posts, only: [:index] |
|
hmm, seems bit unnecessary in my opinion! But PRs are welcome (they will be rejected in this case though :D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this works because when we call add_state
we build a table of known states