Issue 8 status helpers not working properly #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyuva
force-pushed
the
issue-8-status-helpers-not-working-properly
branch
from
d2e70d6 to
fc0907d
Compare
| @@ -37,6 +37,7 @@ def prepare_mos_attributes | |||
| self.states = HashWithIndifferentAccess.new | |||
| self.events = HashWithIndifferentAccess.new | |||
|
|
|||
| after_initialize :set_initial_states | |||
| before_create :set_initial_states | |||
There was a problem hiding this comment.
Do we still need before_create callback then? Also, IIRC after_initialize had a performance penalty - thats the reason I probably did not use it.
There was a problem hiding this comment.
let me checkout how AR initializes columns to default values.
|
so, we dont need |
… while loading form db
gnufied
pushed a commit
that referenced
this pull request
Nov 28, 2014
…orking-properly Issue 8 status helpers not working properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8