Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CURLRequest] body contains "HTTP/1.0 200 Connection established" #9285

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: [CURLRequest] body contains "HTTP/1.0 200 Connection established" #9285

merged 2 commits into from
Nov 29, 2024

Conversation

ping-yee
Copy link
Contributor

Description
Fix #8526

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn
michalsn requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add a changelog entry.

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 18, 2024
@ping-yee
Copy link
Contributor Author

@michalsn Done. review please.

michalsn
michalsn approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@paulbalandan paulbalandan merged commit 979ba49 into codeigniter4:develop Nov 29, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [CURLRequest] body contains "HTTP/1.0 200 Connection established"
3 participants
@ping-yee @michalsn @paulbalandan