Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Postgre\Connection::reconnect() TypeError in pg_ping() #9279

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: Postgre\Connection::reconnect() TypeError in pg_ping() #9279

wants to merge 3 commits into from
+4 −2

Conversation

ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Nov 14, 2024 •
edited by paulbalandan
Loading

Description
Fix #9043

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ping-yee ping-yee changed the title Bug: TypeError in pg_ping() fix: TypeError in pg_ping() Nov 14, 2024
michalsn
michalsn requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a changelog entry under Bugs Fixed section: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.5.6.rst

@michalsn michalsn linked an issue Nov 14, 2024 that may be closed by this pull request
Bug: TypeError in pg_ping() #9043
Open
@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 16, 2024
michalsn
michalsn requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change a changelog entry to be more specific?

user_guide_src/source/changelogs/v4.5.6.rst Outdated Show resolved Hide resolved
@michalsn michalsn changed the title fix: TypeError in pg_ping() fix: Postgre\Connection::reconnect() TypeError in pg_ping() Nov 19, 2024
michalsn
michalsn approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@paulbalandan
Copy link
Member

paulbalandan commented Nov 29, 2024 •
edited
Loading

Hi @ping-yee , one last rebase please and we can merge this. And fixing the conflict. Thank you!

@paulbalandan paulbalandan changed the title fix: Postgre\Connection::reconnect() TypeError in pg_ping() fix: Postgre\Connection::reconnect() TypeError in pg_ping() Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: TypeError in pg_ping()
4 participants
@ping-yee @paulbalandan @michalsn @samsonasik