refactor: flip assert and actual value position on tests #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
samsonasik
changed the title
|
Ready to merge 👍 |
kenjis
reviewed
Nov 8, 2024
Comment on lines
-215
to
+218
| $expects = $closure(...$router->params()); | ||
| $actual = $closure(...$router->params()); | ||
|
|
||
| $this->assertIsCallable($router->controllerName()); | ||
| $this->assertSame($expects, '123-alpha'); | ||
| $this->assertSame('123-alpha', $actual); |
There was a problem hiding this comment.
latest main branch, the flip process yes 👍 , variable rename from expects to actual was manually of course :)
kenjis
approved these changes
Nov 8, 2024
|
Thank you @kenjis for the review 👍 , let's merge it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the actual value should be on the right.
Checklist: