Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spark filter:check shows filter classnames #8985

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 22, 2024

Needs #8977

Description
Before:

$ ./spark filter:check GET admin/users/list

CodeIgniter v4.5.2 Command Line Tool - Server Time: 2024-06-24 00:57:28 UTC+00:00

+--------+------------------+----------------------------------------------+-------------------------------------------------------+
| Method | Route            | Before Filters                               | After Filters                                         |
+--------+------------------+----------------------------------------------+-------------------------------------------------------+
| GET    | admin/users/list | forcehttps pagecache csrf:config csrf:region | csrf:region csrf:config pagecache performance toolbar |
+--------+------------------+----------------------------------------------+-------------------------------------------------------+

After:

$ ./spark filter:check GET admin/users/list

CodeIgniter v4.5.2 Command Line Tool - Server Time: 2024-06-22 02:52:05 UTC+00:00

+--------+------------------+----------------------------------------------+-------------------------------------------------------+
| Method | Route            | Before Filters                               | After Filters                                         |
+--------+------------------+----------------------------------------------+-------------------------------------------------------+
| GET    | admin/users/list | forcehttps pagecache csrf:config csrf:region | csrf:region csrf:config pagecache performance toolbar |
+--------+------------------+----------------------------------------------+-------------------------------------------------------+

Before Filter Classes:
CodeIgniter\Filters\ForceHTTPS → CodeIgniter\Filters\PageCache → CodeIgniter\Filters\CSRF:config → CodeIgniter\Filters\CSRF:region
After Filter Classes:
CodeIgniter\Filters\CSRF:region → CodeIgniter\Filters\CSRF:config → CodeIgniter\Filters\PageCache → CodeIgniter\Filters\PerformanceMetrics → CodeIgniter\Filters\DebugToolbar
--- a/app/Config/Routes.php
+++ b/app/Config/Routes.php
@@ -6,3 +6,11 @@ use CodeIgniter\Router\RouteCollection;
  * @var RouteCollection $routes
  */
 $routes->get('/', 'Home::index');
+
+$routes->group('admin', ['filter' => 'csrf:config'], static function ($routes) {
+    $routes->get('/', 'Admin\Admin::index');
+
+    $routes->group('users', ['filter' => 'csrf:region'], static function ($routes) {
+        $routes->get('list', 'Admin\Users::list');
+    });
+});

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft June 22, 2024 02:53
@kenjis kenjis added enhancement PRs that improve existing functionalities 4.6 labels Jun 22, 2024
@kenjis kenjis force-pushed the feat-spark-filter-check-show-filter-classes branch from ee744a3 to e369260 Compare June 22, 2024 03:03
@kenjis kenjis force-pushed the feat-spark-filter-check-show-filter-classes branch from e369260 to a0219d7 Compare June 24, 2024 00:53
@kenjis kenjis marked this pull request as ready for review June 24, 2024 01:00
@kenjis kenjis marked this pull request as draft June 24, 2024 01:01
@kenjis kenjis marked this pull request as ready for review June 24, 2024 01:12
@kenjis kenjis merged commit adc6598 into codeigniter4:4.6 Jun 27, 2024
42 checks passed
@kenjis kenjis deleted the feat-spark-filter-check-show-filter-classes branch June 27, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants