Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Session::stop() does not destroy session #7503

Merged
merged 2 commits into from
May 19, 2023
Merged

fix: Session::stop() does not destroy session #7503

merged 2 commits into from
May 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 17, 2023 •
edited
Loading

Description
Closes #7501

See #7501 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 17, 2023
@kenjis kenjis mentioned this pull request May 17, 2023
Closed
@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label May 18, 2023
@kenjis kenjis mentioned this pull request May 18, 2023
Closed
@kenjis kenjis merged commit 509b38a into codeigniter4:develop May 19, 2023
@kenjis kenjis deleted the fix-session-stop branch May 19, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Session::stop() does not destroy Session
3 participants
@kenjis @lonnieezell @michalsn