Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declared session in BaseController to avoid Creation of dynamic property in php 8.2 #6996

Merged
merged 8 commits into from Dec 24, 2022
Merged

Declared session in BaseController to avoid Creation of dynamic property in php 8.2 #6996

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d099945
Declared session in BaseController to avoid 8.2 depreciation
thenerdyshark Dec 20, 2022
1e1d24b
Fix: Creation of dynamic property depreciation to allow for session i…
thenerdyshark Dec 20, 2022
7b4d9b9
Commented session property declaration
thenerdyshark Dec 20, 2022
4a7df00
Merge branch 'codeigniter4:develop' into develop
thenerdyshark Dec 22, 2022
0f7098d
Edited comment regarding property and changed from public to protecte…
thenerdyshark Dec 22, 2022
a6d64d0
Update app/Controllers/BaseController.php
thenerdyshark Dec 23, 2022
b19bb0e
Merge branch 'codeigniter4:develop' into develop
thenerdyshark Dec 23, 2022
a2c47fa
Update app/Controllers/BaseController.php
thenerdyshark Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/Controllers/BaseController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ abstract class BaseController extends Controller
*/
protected $helpers = [];

/**
* Be sure to declare properties for anything you assign.
This conversation was marked as resolved.
Show resolved Hide resolved
* The creation of dynamic property is deprecated in PHP 8.2.
*/
// protected $session;

/**
* Constructor.
*/
Expand Down