Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict checking for SQLite3 memory filename #4161

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

paulbalandan
Copy link
Member

Description
According to the SQLite documentation,

Note that in order for the special ":memory:" name to apply and to create a pure in-memory database, there must be no additional text in the filename. Thus, a disk-based database can be created in a file by prepending a pathname, like this: "./:memory:".

Thus, we need to be strictly checking if the name is :memory: rather than checking if it is part of the name.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit 0ae2e20 into codeigniter4:develop Jan 26, 2021
@paulbalandan paulbalandan deleted the db-create-fix-memory branch January 26, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants