Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for retrieving migration history #4147

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

michalsn
Copy link
Member

Description
This PR fixes the way we loading the history of migrations so that all migrations can be checked and not only these from the default group.

Fixes #4142

Checklist:

  • Securely signed commits
  • Conforms to style guide

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does this close that issue though, or just the group discrepancy?

@michalsn
Copy link
Member Author

The group discrepancy is probably the only valid issue there. But I will wait for the author's response.

@MGatner
Copy link
Member

MGatner commented Jan 24, 2021

@michalsn Do you think this is related to #3359? And thus to lonnieezell/myth-auth#298 ?

@michalsn
Copy link
Member Author

@MGatner Not really. The issues you mentioned seem to be related to the lack of a database extension enabled in the CLI environment.

In the original issue, I have linked, the problem with the connection is most likely related to some problems with passing environment variables.

@MGatner
Copy link
Member

MGatner commented Jan 24, 2021

The weird thing in these cases is that the migration would actually succeed (create the table) even with the error. I suspect the issues stemmed from multiple sources and somehow got convoluted. Oh well.

This one all set? Good by me.

@michalsn
Copy link
Member Author

Yes... I'm not sure how accurate are some of these reported issues. It seems impossible to have a connection error and successfully processed migrations at the same time 🤷‍♂️

This is ready - I will just wait for the confirmation from the original issue creator.

@michalsn michalsn merged commit 361c6e8 into codeigniter4:develop Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: PostgreSQL driver issues
2 participants