Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset data cache after SQLite3 table modifications #3753

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 10, 2020

Description
Resets the connection dataCache after SQLite modified table structures to ensure that the new structures are rediscovered. This is a bit of a "blast" fix but should be performance-safe because of when Forge is actually used.

Fixes #3752.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented Oct 10, 2020

Not sure about the Coveralls failure. It says coverage increased?

COVERAGE INCREASED (+1.4%)

@paulbalandan
Copy link
Member

Not sure about the Coveralls failure. It says coverage increased?

COVERAGE INCREASED (+1.4%)

Coveralls has been weird lately. In my PR it says the coverage decreased but in the webpage it says it increased. Not sure which to trust. 😂

@michalsn
Copy link
Member

I would treat Coveralls results with caution today because builds for some reason again take around 100 minutes... 🤣 and I don't think we merged anything that could cause this.

Results for coverage are strange, we have increases and one decrese 🤷

@MGatner MGatner merged commit 5991ae3 into codeigniter4:develop Oct 10, 2020
@MGatner MGatner deleted the sqlite-datacache branch October 10, 2020 17:39
@paulbalandan
Copy link
Member

I would treat Coveralls results with caution today because builds for some reason again take around 100 minutes... 🤣 and I don't think we merged anything that could cause this.

Results for coverage are strange, we have increases and one decrese 🤷

I've checked the logs of recent runs and it seems tests starting at 87% until 100% (the live tests) are taking an average of an hour to finish. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SQLite drop column corrupts table cache
3 participants