Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localeSegment reset #3406

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Fix localeSegment reset #3406

merged 1 commit into from
Jul 25, 2020

Conversation

michalsn
Copy link
Member

Description
This PR fixes $localeSegment reset. Resetting wasn't triggered every time and it was causing problems.

See: #3386

Checklist:

  • Securely signed commits
  • Conforms to style guide

MGatner
MGatner approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on tests but looks right to me

@michalsn michalsn merged commit 41435d6 into codeigniter4:develop Jul 25, 2020
@michalsn michalsn deleted the fix/localeSegment branch September 5, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @MGatner