Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldData -> add typeName field and length field #3299

Merged
merged 3 commits into from
Jul 13, 2020
Merged

FieldData -> add typeName field and length field #3299

merged 3 commits into from
Jul 13, 2020

Conversation

devorama
Copy link
Contributor

As per pull request
#3287
added field type name.
had to redo it as I had to re-fork the repo and that broke the previous pull request.

Will return NULL if mapped field type name not found

the DB version of the type returned by driver is stored in the type column

Where applicable length is stored or made equal to max_length as in for example MySQL the max_length is based on
the data returned and not the DB schema where length is closer to the truth but still not 100%
cant think of a alternative that wont be affect the performance of the procedure. Is a need if want to build schema
from this data in the future

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

devorama added 3 commits July 13, 2020 11:47
linked to this pull request
#3287
linked to this pull request
#3287
@devorama devorama changed the title Devorama database fielddata add typename FieldData -> add typeName field and length field Jul 13, 2020
@michalsn
Copy link
Member

Yay! We made it finally 🥳

Thank you @devorama!

@michalsn michalsn merged commit 6ad591a into codeigniter4:develop Jul 13, 2020
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants