Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce repetitive getDefaultNamespace() and controllerName() function call in Router #3298

Merged
merged 2 commits into from
Jul 13, 2020
Merged

reduce repetitive getDefaultNamespace() and controllerName() function call in Router #3298

merged 2 commits into from
Jul 13, 2020

Conversation

samsonasik
Copy link
Member

Checklist:

  • Securely signed commits

michalsn
michalsn reviewed Jul 13, 2020
View reviewed changes
system/Router/Router.php Outdated Show resolved Hide resolved
@samsonasik samsonasik force-pushed the reduce-repetitive-func-call-in-router branch from d2c77e7 to 56c780b Compare July 13, 2020 13:13
@michalsn michalsn merged commit 4334459 into codeigniter4:develop Jul 13, 2020
@michalsn
Copy link
Member

Thank you!

@samsonasik samsonasik deleted the reduce-repetitive-func-call-in-router branch July 13, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @michalsn @MGatner