Fix. redirect custom HTTP Code not work #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Instrye it looks like there was more discussion on the issue since this PR. Is this ready for review? |
Yes,It ready. |
kenjis
reviewed
Apr 20, 2023
| $this->codeigniter->useSafeOutput(true)->run(); | ||
| ob_get_clean(); | ||
| $response = $this->getPrivateProperty($this->codeigniter, 'response'); | ||
| $this->assertEquals('303', $response->getStatusCode()); |
There was a problem hiding this comment.
Why is this code changed to 303?
The route sets the status code 301.
There was a problem hiding this comment.
I sent a PR to fix the behavior: #7445
There was a problem hiding this comment.
CodeIgniter4/system/HTTP/ResponseTrait.php
Line 519 in e151d3a
There was a problem hiding this comment.
Essentially it should be 301, but the handler is written so that the custom response code is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3041
Thanks @MichalPB1 's suggest
Redirect HTTP Code can't work. when method is get, it always set as 307.
Checklist: