Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing InvalidArgumentException in Database\BaseBuilder #2813

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fix missing InvalidArgumentException in Database\BaseBuilder #2813

merged 2 commits into from
Apr 9, 2020

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 9, 2020 •
edited
Loading

Fix missing "\" prefix in throw InvalidArgumentException.

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@samsonasik
Copy link
Member Author

I've added unit tests for it.

@samsonasik
Copy link
Member Author

travis build green 🎉

@MGatner MGatner merged commit 895f1e6 into codeigniter4:develop Apr 9, 2020
@samsonasik samsonasik deleted the fix-missing-invalidargumentexception-basebuilder branch April 9, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @MGatner