Subfolder base_url() with parameter #2574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when providing a URI parameter to
base_url()
if it has a preceding slash it will cause the resulting URL to be relative to the root domain, rather than a subfolder defined inapp.baseUrl
. This PR trims preceding and trailing slashes in the helper to ensure the result fromHTTP\URI
is still relative to the base URL.May fix some of #2445, hard to say without being able to replicate.
Checklist: