Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image verification #2573

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Image verification #2573

merged 4 commits into from
Feb 20, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Feb 18, 2020

Description
Currently the framework fails with unhelpful messages if any of the Image handler functions are used without first calling withFile() on a valid image file path. This PR adds some checks that withFile() has been invoked and its source is an actual image.

Fixes #2421.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner changed the title WIP Image verification Image verification Feb 19, 2020
@MGatner MGatner requested a review from lonnieezell February 19, 2020 18:58
@MGatner
Copy link
Member Author

MGatner commented Feb 19, 2020

@lonnieezell I think this one is set, give it a quick glance?

@lonnieezell lonnieezell merged commit 489c2bf into codeigniter4:develop Feb 20, 2020
@MGatner MGatner deleted the image-withfile branch February 20, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ImageHandler has no reality checks
2 participants