Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2373 Update kint-php version to 3.3 #2542

Closed

Conversation

musmanikram
Copy link
Contributor

@musmanikram musmanikram commented Feb 12, 2020

Update kint version to 3.3 #2373

Description
Update package dependency version for kint-php/kint from 2.1 to 3.3

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@musmanikram musmanikram changed the title Update kint-php version to 3.3 2373 Update kint-php version to 3.3 Feb 12, 2020
@lonnieezell
Copy link
Member

Unfortunately, there's much more to it than this. While your fix works fine for composer-based installs, it will fail completely for those that want to simply download a release and not use composer.

For those, the post-install script has to be modified to copy the files into the appropriate place, and then everything has to work smoothly. I had attempted this at one point and ran into issues there, as described in the issue you referenced. Haven't had an opportunity to get back to it just yet.

@musmanikram
Copy link
Contributor Author

Unfortunately, there's much more to it than this. While your fix works fine for composer-based installs, it will fail completely for those that want to simply download a release and not use composer.

For those, the post-install script has to be modified to copy the files into the appropriate place, and then everything has to work smoothly. I had attempted this at one point and ran into issues there, as described in the issue you referenced. Haven't had an opportunity to get back to it just yet.

I will try to fix zip issue. But is it very important to give support for zip download? I mean we can enforce to use only composer. Otherwise, we have to support both and will face these issues in future,

@lonnieezell
Copy link
Member

But is it very important to give support for zip download?

Yes. That is the CodeIgniter legacy. And, at least with v4, we are keeping the ability to download and go, just like we're keeping the ability to auto-route based on the URL. These are things that helped make CI what it is, and we are trying to make an improved version of an existing framework, not creating a brand new framework, so we do have to keep the feel where possible, and the things many many have loved about it, whether or not we all want to use that style of programming.

@musmanikram
Copy link
Contributor Author

But is it very important to give support for zip download?

Yes. That is the CodeIgniter legacy. And, at least with v4, we are keeping the ability to download and go, just like we're keeping the ability to auto-route based on the URL. These are things that helped make CI what it is, and we are trying to make an improved version of an existing framework, not creating a brand new framework, so we do have to keep the feel where possible, and the things many many have loved about it, whether or not we all want to use that style of programming.

ahh that make sense. I will try to spend some time it.

@musmanikram
Copy link
Contributor Author

I noticed it's a bit tricky now. I am closing this PR and we can see this issue in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants