Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Events information in the 'Upgrading from 3.x to 4.x' section #2522

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

jlamim
Copy link
Contributor

@jlamim jlamim commented Jan 30, 2020

Description
According to issue #2521 , this commit adds information about replacing Hooks with Events in the 'Upgrading from 3.x to 4.x' section of the official documentation.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Jan 30, 2020

I was literally typing this when I got the notice. Good show :)

@MGatner MGatner merged commit 6d4e847 into codeigniter4:develop Jan 30, 2020
@jlamim
Copy link
Contributor Author

jlamim commented Jan 30, 2020

@MGatner , I am checking the Open Issues to see what documentation has to adjust or add. If you have any of the documentation to be done and you have no issues open, tell me that I will try to help in whatever way possible.

@MGatner
Copy link
Member

MGatner commented Jan 30, 2020

Thanks so much! That's a great help. I thought there were a couple more, but I haven't been through the whole list. I'll mention you as I come across things.

Don't forget, if you're updating non-functional code (like the User Guide) you can preface your commits with "[ci skip]" to prevent the pipeline from running all the tests!

@jlamim
Copy link
Contributor Author

jlamim commented Jan 30, 2020

@MGatner after I did PR, I remembered [ci skip], sorry.

@MGatner
Copy link
Member

MGatner commented Jan 30, 2020

Hey no sweat, I'd rather have all the commits without it than no commits at all! You're work is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants