Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. CodeIgniter/View/Parser::render allow other extension #2233

Closed
wants to merge 2 commits into from
Closed

fix. CodeIgniter/View/Parser::render allow other extension #2233

wants to merge 2 commits into from

Conversation

nyufeng
Copy link
Contributor

@nyufeng nyufeng commented Sep 20, 2019

Fix bug from #2086
reference CodeIgniter/View/View::render

@panigrc
Copy link

panigrc commented Sep 20, 2019

The extension should be configurable instead of hardcoded php.
I would expect a constant i.e. VIEW_FILE_EXTENSION

That's probably for another feature request sorry.

@jim-parry
Copy link
Contributor

This should have unit tests to demonstrate that a .html or whatever view file can be successfully rendered.

@nyufeng nyufeng closed this Sep 24, 2019
@nyufeng nyufeng deleted the patch-1 branch September 24, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants