-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Migration updates for more wholistic functionality #2065
Conversation
Yay! This is looking great. Let me know if I can help with anything. |
system/Database/MigrationRunner.php
Outdated
@@ -323,7 +312,8 @@ public function latestAll(string $group = null): bool | |||
} | |||
|
|||
// Get all namespaces from the autoloader | |||
$namespaces = Services::autoloader()->getNamespace(); | |||
$namespaces = Services::autoloader() | |||
->getNamespace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typing mistake
…rscores or dashes now.
…rest of the framework.
Awesome! Very excited to try this out. I’ll give it a run through this morning. |
@lonnieezell I think there might be a problem. I'll go over it some more in case it is something I'm doing, but migrations aren't matching their versions. I think the issue is that
|
Yes the issue is with numeric migration versions - |
Okay easy fix is union instead of merge; PR incoming. |
I downloaded CI4 via composer (devstarter). But there's problem with migrate:create. For some reason in App\Config\Migration.php file there's no timestampFormat variable. This code below is missing /* And this is the error of command line
` But after adding missing code it works greate. Thank you for your attention |
That’s odd, it’s definitely there: CodeIgniter4/app/Config/Migrations.php Line 48 in 6f156c5
After installing did you run |
I've tried |
That’s because I’m a dummy - that will only update Config in vendor/codeigniter4/codeigniter4/app. Could you check that the correct version is there? And @jim-perry might need to update the deployment process to seed the new version. |
With the devstarter, composer update only updates the dependencies, i.e. vendor/codeigniter4/codeigniter4. Any changes to app, public, tests & writable will be inside vendor/codeigniter4/... and will need to be copied to the project's app, public, etc. |
Many of these changes are to help unify migrations across multiple namespaces for when modular code patterns are used.
current
concept. This can be handled better through version control branch management by the developer, and doesn't play well with multiple namespaces.20180115011221
) or a more readable version (2018_01_15_011221
)