Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make force_https() send headers before exit #2036

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jun 3, 2019

Description
force_https() is calling exit() before applying the header set by $response->redirect(), so the browser treats it as a clean exit, no errors (i.e. blank page). Fix for #2033

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 95c46d5 into codeigniter4:develop Jun 3, 2019
@MGatner MGatner deleted the fix-force_https-redirect branch June 3, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants