Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument set() must by type of string - cannot agree #1989

Merged
merged 1 commit into from
May 15, 2019

Conversation

nowackipawel
Copy link
Contributor

set should accept at least NULL | int | string
UPDATE x SET a = NULL ...
UPDATE x SET a = 100
UPDATE x SET a = 'aaa'

set should accept NULL
UPDATE x SET a = NULL ...
@lonnieezell
Copy link
Member

I'll merge but to be fair, due to the nature of PHP - all of those items you show, null, int, and string get typecast during that method, I believe.

@lonnieezell lonnieezell merged commit c8c9091 into codeigniter4:develop May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants