Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/featuretestcase #1977

Merged
merged 3 commits into from
May 2, 2019
Merged

Conversation

jim-parry
Copy link
Contributor

@jim-parry jim-parry commented May 1, 2019

  • added 'patch' to allowed HTTP verbs in RouteCollection
  • added resetRoutes() in RouteCollection, to support FeatureTestCase
  • added output capturing to FeatureTestCase::call
  • added more methods to tests/_support/Controllers/Popcorn, to generate all the different kinds of responses
  • added note to testing/features in user guide

Related to #1767, #1692 & possibly #1697
Closes #1767

@jim-parry
Copy link
Contributor Author

Three SQLite3 tests are failing, and there are some warnings for SQLite3 too.
I don't see these being related to the current PR, though they pass travis-ci for other PRs.
This should be ready to go, as far as I can tell.

@lonnieezell
Copy link
Member

Doesn't look like those tests are affected by anything you did. They seem to be missing a $refresh = true or similar on those test classes.

@jim-parry
Copy link
Contributor Author

I think there is something screwy with travis-ci.
I re-ran the test suite that failed, and now three different tests fail - Validation ones.
It seems that the db_user table is sometimes there for SQLite3, and sometimes not.

@jim-parry jim-parry merged commit e0d48a4 into codeigniter4:develop May 2, 2019
@jim-parry jim-parry deleted the test/featuretestcase branch May 2, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller Test / Feature Testing output issues
2 participants