Fix datetime extraction from debugbar file #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the full path of debugbar file contains some digits, the first group of digits was extracted as timestamp and the datetime displayed in the Hisory toolbar was wrong.
|
Please give reference to the created issue number. That will help to identify the issue. |
Sorry, the issue number is 1944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/codeigniter4/CodeIgniter4/issues/1944
When the full path of debugbar file contains some digits, the first group of digits was extracted as timestamp and the datetime displayed in the Hisory toolbar was wrong.
Description
Changed how the time is extracted from bedugbar filename by getting the las group of digits founded by preg_match_all function.
Checklist: